Repository navigation
codegen: the int32-key element read passes the split helper its key-fact argument (main does not compile) - #14461
Merged
Conversation
…act argument (main did not compile)
Pre-merge checks:
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Title check |  |
This assessment has not completed. The check will be retried on the next pre-merge check run. | |
| Description check | |
This assessment has not completed. The check will be retried on the next pre-merge check run. |
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main does not compile
perry-codegensince 5bdb09d:crates/perry-codegen/src/expr/index_get.rs, E0061,lower_array_index_get_via_canonical_i32_splittakes 10 arguments and the int32-key call site supplies 9.Key signs (#14458) added the
key: Option<KeyFact>parameter; int32 local ranges (#14453) added a new call site at the same time. Each compiled alone, and the merge was textually clean.The fix passes
Noneat that site. The key there is already an i32 (int32_key::lower), which the split takes as a native key; a key-sign fact would runexact_i32on it as if it were a double. This is the behavior #14453 shipped.Checked:
cargo check -p perry-codegen --libon main 41443b0 plus this change. Not built in release and not measured.